Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added share with twitter button #1114

Closed
wants to merge 2 commits into from
Closed

feat: added share with twitter button #1114

wants to merge 2 commits into from

Conversation

ptdatta
Copy link
Contributor

@ptdatta ptdatta commented Aug 7, 2023 •
edited by pr-codex bot
Loading

fixes: #1061

simplescreenrecorder-2023-08-07_12.15.11.mp4

PR-Codex overview

The following files were skipped due to too many changes: yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

❌ Deploy Preview for kleros-v2 failed.

Name Link
🔨 Latest commit 4985fa9
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/652dcd080a06250008609148

@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 6546c57
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64d09365a098b200080dec32
😎 Deploy Preview https://deploy-preview-1114--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ptdatta ptdatta mentioned this pull request Aug 7, 2023
Closed
@ptdatta
Copy link
Contributor Author

ptdatta commented Aug 7, 2023 •
edited
Loading

@jaybuidl Currently, I only added the Share with Twitter button. I have some questions:

  1. Does I changed the Twitter to X?
  2. I am not sure about the UI. Should I use the Share your Jouor Score text for all three platforms? And will they be rowwise or columnwise? As rowise they will not fit?
  3. Currently the message is:
    Hey I've been busy as a Juror on the Kleros court,
    check out my score! https://kleros.io/
  4. Why you use styled components in stead of tailwind?
    Should I change it?

@kemuru
Copy link
Contributor

kemuru commented Aug 18, 2023 •
edited
Loading

Dont push subgraph files in the PR, you can commit again removing them. To answer your points:

  1. Yeah it should be X branding, not Twitter
  2. "Share your Juror Score" looks fine to me. Curious about what @nhestrompia @alcercu @jaybuidl think
  3. The message looks good to me too, except linking to https://kleros.io/ is not sharing your juror score
  4. We are currently using styled components instead of tailwind for better scaling so its better we stick to it

@ptdatta
Copy link
Contributor Author

ptdatta commented Aug 19, 2023

@kemuru Thanks for the feedback.

@ptdatta
Copy link
Contributor Author

ptdatta commented Aug 19, 2023

@kemuru @jaybuidl are you using some special kind of svgs as when I use another svg when I downloaded from another site the app stopped working??

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 16, 2023

Code Climate has analyzed commit 4985fa9 and detected 0 issues on this pull request.

View more on Code Climate.

@kemuru
Copy link
Contributor

kemuru commented Oct 24, 2023

hey, @ptdatta appreciate your contribution. i'm going to continue this PR here -> #1297
the reason is I had some problems with joining your branch, but you are be credited there, and again thanks for your interest

@kemuru kemuru closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Feature🗿
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gamification: buttons to let the user share their score on social media
3 participants
@ptdatta @kemuru @jaybuidl